-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Unit Test for Verhoeff #37195
Merged
andy31415
merged 6 commits into
project-chip:master
from
tersal:create-unit-test-for-verhoeff-module
Jan 28, 2025
Merged
Basic Unit Test for Verhoeff #37195
andy31415
merged 6 commits into
project-chip:master
from
tersal:create-unit-test-for-verhoeff-module
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #37195: Size comparison from 14ac7a6 to 3369a48 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
PR #37195: Size comparison from 14ac7a6 to 67c4224 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tersal
changed the title
[WIP] Create basic Unit Test for Verhoff
[WIP] Create basic Unit Test for Verhoeff
Jan 24, 2025
PR #37195: Size comparison from 14ac7a6 to 9f2ed7b Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tersal
changed the title
[WIP] Create basic Unit Test for Verhoeff
Basic Unit Test for Verhoeff
Jan 26, 2025
andy31415
approved these changes
Jan 27, 2025
andy31415
reviewed
Jan 27, 2025
PR #37195: Size comparison from 14ac7a6 to ce384d7 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jan 28, 2025
Editorial commit: remove extra `sources = []`, I expect our templates to handle this one missing.
andy31415
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #37114
Basically is the creation of a new set of unit tests focused on the Verhoeff algorithm for checksums.
Testing
Tested with the script build_coverage.sh as part of the Unit Tests.